From 353fb545db45c48343715a5c3f107ca6c99ef07e Mon Sep 17 00:00:00 2001 From: Steffen Vogel Date: Thu, 7 Mar 2024 16:13:02 +0000 Subject: [PATCH] node: Fix null-pointer dereference for internal loopback nodes Signed-off-by: Steffen Vogel --- lib/node.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/node.cpp b/lib/node.cpp index e9a7e9017..ef9a07250 100644 --- a/lib/node.cpp +++ b/lib/node.cpp @@ -74,7 +74,10 @@ Node::~Node() { rtnl_cls_put(tc_classifier); #endif // WITH_NETEM - factory->instances.remove(this); + // Internal loopback nodes have no factory + // Only attempt removal for factories of other node-types. + if (factory != nullptr) + factory->instances.remove(this); } int Node::prepare() {