From 5f44e16ced1ed7dda03e271e538984903e1eb075 Mon Sep 17 00:00:00 2001 From: Niklas Eiling Date: Mon, 29 Jul 2024 10:28:51 +0000 Subject: [PATCH] fpga: remove dead code and improve comments in Dino IP Signed-off-by: Niklas Eiling --- fpga/lib/ips/dino.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fpga/lib/ips/dino.cpp b/fpga/lib/ips/dino.cpp index b3fe9e7e5..539c726d9 100644 --- a/fpga/lib/ips/dino.cpp +++ b/fpga/lib/ips/dino.cpp @@ -153,12 +153,14 @@ void DinoAdc::setRegisterConfig(std::shared_ptr reg, reg->setRegister( dinoRegisterTimer, dinoTimerVal); // Timer value for generating ADC trigger signal + // The following are calibration values for the ADC and DAC. Scale + // sets an factor to be multiplied with the input value. This is the + // raw 16 bit ADC value for the ADC and the float value from VILLAS for + // the DAC. Offset is a value to be added to the result of the multiplication. + // All values are IEE 754 single precision floating point values. reg->setRegister(dinoRegisterAdcScale, -0.001615254F); // Scale factor for ADC value reg->setRegister(dinoRegisterAdcOffset, 10.8061F); // Offset for ADC value - - // reg->setRegister(dinoRegisterDacScale, - // 3276.75F); // Scale factor for DAC value reg->setRegister(dinoRegisterDacScale, 3448.53852516F); // Scale factor for DAC value reg->setRegister(dinoRegisterDacOffset, 32767.5F); // Offset for DAC value