Mirrors/libhermit
1
0
Fork 0
mirror of https://github.com/hermitcore/libhermit.git synced 2025-03-09 00:00:03 +01:00
Code Issues Releases Wiki Activity

avoid race by removing memset

Browse source
This commit is contained in:
Stefan Lankes 2016-02-15 18:28:49 +01:00
parent 22be514ed1
commit c84d638aa9
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
hermit/arch/x86/mm/page.c
View file

@ -324,6 +324,7 @@ void page_fault_handler(struct state *s)
// on demand userspace heap mapping
viraddr &= PAGE_MASK;
// TODO: a function to get zeroed pages is missing
size_t phyaddr = get_page();
if (BUILTIN_EXPECT(!phyaddr, 0)) {
kprintf("out of memory: task = %u\n", task->id);
@ -338,7 +339,7 @@ void page_fault_handler(struct state *s)
goto default_handler;
}
memset((void*) viraddr, 0x00, PAGE_SIZE); // fill with zeros
// TODO: reusing of old data is possible => security issue
spinlock_irqsave_unlock(task->page_lock);