From 66afd3da7822c11a297965586d1583ed1586456b Mon Sep 17 00:00:00 2001 From: Andy Green Date: Sun, 17 Oct 2021 07:48:40 +0100 Subject: [PATCH] coverity: client_reset: no longer any way to get NULL *pwsi Coverity belatedly noticed that client_reset no longer changes *pwsi --- lib/roles/http/client/client-http.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/lib/roles/http/client/client-http.c b/lib/roles/http/client/client-http.c index 221f394de..7dce85000 100644 --- a/lib/roles/http/client/client-http.c +++ b/lib/roles/http/client/client-http.c @@ -819,21 +819,9 @@ lws_client_interpret_server_handshake(struct lws *wsi) } if (!lws_client_reset(&wsi, ssl, ads, port, path, ads, 1)) { - /* - * There are two ways to fail out with NULL return... - * simple, early problem where the wsi is intact, or - * we went through with the reconnect attempt and the - * wsi is already closed. In the latter case, the wsi - * has been set to NULL additionally. - */ lwsl_err("Redirect failed\n"); cce = "HS: Redirect failed"; - /* coverity[reverse_inull] */ - if (wsi) - goto bail3; - - /* wsi has closed */ - return 1; + goto bail3; } /*