From a7f70535911cce3a613b91f22d832769e8bdadd4 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Wed, 10 Mar 2021 15:02:45 +0000 Subject: [PATCH] connect2: log dereferences things that may have been destroyed It's perfectly possible we will have destroyed the wsi and report that back in the return code. So let's not dumbly defreference the wsi to make a log inbetweentimes. Found with fault injection and valgrind. --- lib/core-net/client/connect2.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/core-net/client/connect2.c b/lib/core-net/client/connect2.c index 2e7033454..54bf139d4 100644 --- a/lib/core-net/client/connect2.c +++ b/lib/core-net/client/connect2.c @@ -333,9 +333,6 @@ solo: LWS_ADNS_RECORD_A, lws_client_connect_3_connect, wsi, NULL); - lwsl_notice("%s: %s: post async dns, state 0x%x\n", - __func__, lws_wsi_tag(wsi), lwsi_state(wsi)); - if (n == LADNS_RET_FAILED_WSI_CLOSED) return NULL;