From c398dd546bde7711303f579e23b966c84198fad7 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Fri, 29 Apr 2022 10:45:55 +0100 Subject: [PATCH] coverity: reorder NULL check --- lib/system/metrics/metrics.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/system/metrics/metrics.c b/lib/system/metrics/metrics.c index 92d5e0d0f..1a978cca7 100644 --- a/lib/system/metrics/metrics.c +++ b/lib/system/metrics/metrics.c @@ -437,11 +437,13 @@ int lws_metric_destroy(lws_metric_t **pmt, int keep) { lws_metric_t *mt = *pmt; - lws_metric_pub_t *pub = lws_metrics_priv_to_pub(mt); + lws_metric_pub_t *pub; if (!mt) return 0; + pub = lws_metrics_priv_to_pub(mt); + lws_dll2_remove(&mt->list); if (keep) {