From df2f135c096de2906462c58daddd34f44d0699a7 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Fri, 14 Aug 2020 07:18:48 +0100 Subject: [PATCH] coverity: 324692: mqtt: check for OOM in generate_id --- lib/roles/mqtt/client/client-mqtt.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/roles/mqtt/client/client-mqtt.c b/lib/roles/mqtt/client/client-mqtt.c index a871bfefc..f6c2a374a 100644 --- a/lib/roles/mqtt/client/client-mqtt.c +++ b/lib/roles/mqtt/client/client-mqtt.c @@ -81,7 +81,11 @@ lws_mqtt_generate_id(struct lws* wsi, lws_mqtt_str_t **ms, const char *client_id buf[len] = '\0'; } - lws_mqtt_str_advance(*ms, (uint16_t)len); + if (lws_mqtt_str_advance(*ms, (uint16_t)len)) { + lws_mqtt_str_free(ms); + + return 1; + } return 0; }