From f5c200b2e46384703d73f837ea3abba0c0e7a73b Mon Sep 17 00:00:00 2001 From: p-luke <105498880+p-luke@users.noreply.github.com> Date: Thu, 16 May 2024 14:44:44 +0200 Subject: [PATCH] cmake: do not allow netlink support when external poll support is enabled. Netlink fds are not passed to the user callback for external loop adoption, because vhost and its protocols are not yet in place when rops_pt_init_destroy_netlink() gets called during context creation. As a consequence, netlink fds are not polled, leading to outdated/wrong routing table entries in the library. A complex rework would be required to support this, so for now disable netlink when external poll is needed. --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 07c2604e7..e1c0b8fee 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -335,7 +335,7 @@ else() option(LWS_WITH_CACHE_NSCOOKIEJAR "Build file-backed lws-cache-ttl that uses netscape cookie jar format (linux-only)" OFF) endif() -if (${CMAKE_SYSTEM_NAME} MATCHES "Linux") +if (${CMAKE_SYSTEM_NAME} MATCHES "Linux" AND NOT LWS_WITH_EXTERNAL_POLL) option(LWS_WITH_NETLINK "Monitor Netlink for Routing Table changes" ON) else() set(LWS_WITH_NETLINK 0)