1
0
Fork 0
mirror of https://github.com/warmcat/libwebsockets.git synced 2025-03-23 00:00:06 +01:00
libwebsockets/win32port
Graham Newton 7ee4f890a3 windows workaround unsigned fd in emulated poll
A common practise to temporarily disable a socket in a poll call is to negate the socket fd.  poll should then ignore the socket.
emulated_poll does this with the following code:
        if (poll_fd->fd < 0 || !poll_fd->events)
            goto skip1;

However on Windows the fd field in WSAPOLLFD is unsigned int!!!  So the check for a negative fd value always fails.
This results in select returning an error with an error code of 10038 -- Socket operation on nonsocket.
The fix is to type cast fd like so:
        if ((int)poll_fd->fd < 0 || !poll_fd->events)

This may be the cause of some high CPU load reports.  I noticed the load being 50% with my application running on Windows XP.

Signed-off-by: Graham Newton <gnewton@peavey-eu.com>
2013-11-09 08:11:41 +08:00
..
client Added "Release DLL" configuration. 2011-09-26 17:30:34 +01:00
libwebsocketswin32 remove deprecated vcxproj 2013-02-07 20:25:28 +08:00
server Added "Release DLL" configuration. 2011-09-26 17:30:34 +01:00
win32helpers windows workaround unsigned fd in emulated poll 2013-11-09 08:11:41 +08:00
zlib revert zlib update 1.2.7 2013-01-19 15:11:23 +08:00
win32port.sln Added "Release DLL" configuration. 2011-09-26 17:30:34 +01:00