From 3a4c02912ac9325bd91b7059ef3f11e3e6a6aa4b Mon Sep 17 00:00:00 2001 From: klauspost Date: Thu, 13 Aug 2015 14:15:38 +0200 Subject: [PATCH] Disable UID/GID/mode/symlink tests on Windows. Mode will not match the unix mode, since it can only partially be represented. UID/GID are not relevant on Windows. Symlinks cannot be created by non-admins on Windows. --- node_test.go | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/node_test.go b/node_test.go index f6104b49b..5bdf284bb 100644 --- a/node_test.go +++ b/node_test.go @@ -119,6 +119,9 @@ func TestNodeRestoreAt(t *testing.T) { nodePath := filepath.Join(tempdir, test.Name) OK(t, test.CreateAt(nodePath, nil)) + if test.Type == "symlink" && runtime.GOOS == "windows" { + continue + } if test.Type == "dir" { OK(t, test.RestoreTimestamps(nodePath)) } @@ -135,14 +138,16 @@ func TestNodeRestoreAt(t *testing.T) { "%v: type doesn't match (%v != %v)", test.Type, test.Type, n2.Type) Assert(t, test.Size == n2.Size, "%v: size doesn't match (%v != %v)", test.Size, test.Size, n2.Size) - Assert(t, test.UID == n2.UID, - "%v: UID doesn't match (%v != %v)", test.Type, test.UID, n2.UID) - Assert(t, test.GID == n2.GID, - "%v: GID doesn't match (%v != %v)", test.Type, test.GID, n2.GID) - if test.Type != "symlink" { - Assert(t, test.Mode == n2.Mode, - "%v: mode doesn't match (%v != %v)", test.Type, test.Mode, n2.Mode) + if runtime.GOOS != "windows" { + Assert(t, test.UID == n2.UID, + "%v: UID doesn't match (%v != %v)", test.Type, test.UID, n2.UID) + Assert(t, test.GID == n2.GID, + "%v: GID doesn't match (%v != %v)", test.Type, test.GID, n2.GID) + if test.Type != "symlink" { + Assert(t, test.Mode == n2.Mode, + "%v: mode doesn't match (%v != %v)", test.Type, test.Mode, n2.Mode) + } } AssertFsTimeEqual(t, "AccessTime", test.Type, test.AccessTime, n2.AccessTime)