stv0g/libnl
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Clang diagnostics

Browse source 
Based on clang diagnostics:

1. lib/nl.c: recvmsgs(): nla filling with zeros commented.
2. lib/route/classid.c: & lib/route/pktloc.c:
   remove zero-filling of struct stat
3. lib/route/qdisc/htb.c: Fix htb_qdisc_msg_fill(): fix zero-filling
4. ematch/container.c: container_parse:
   commented why only 4 bytes are copied
   len marked as unused to eliminate compiler warning
This commit is contained in:
Коренберг Марк (ноутбук дома) 2012-09-10 01:33:04 +06:00 • committed by Коренберг Марк (дома)
parent fedb862ea5
commit e1b67fb23f
5 changed files with 19 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/nl.c
View file

@ -540,6 +540,12 @@ static int recvmsgs(struct nl_sock *sk, struct nl_cb *cb)
int n, err = 0, multipart = 0, interrupted = 0, nrecv = 0;
unsigned char *buf = NULL;
struct nlmsghdr *hdr;
/*
nla is passed on to not only to nl_recv() but may also be passed
to a function pointer provided by the caller which may or may not
initialize the variable. Thomas Graf.
*/
struct sockaddr_nl nla = {0};
struct nl_msg *msg = NULL;
struct ucred *creds = NULL;

2
lib/route/classid.c
View file

@ -311,7 +311,7 @@ static int classid_map_add(uint32_t classid, const char *name)
int rtnl_tc_read_classid_file(void)
{
static time_t last_read;
struct stat st = {0};
struct stat st;
char buf[256], *path;
FILE *fd;
int err;

8
lib/route/cls/ematch/container.c
View file

@ -14,8 +14,14 @@
#include <netlink/netlink.h>
#include <netlink/route/cls/ematch.h>
static int container_parse(struct rtnl_ematch *e, void *data, size_t len)
static int container_parse(struct rtnl_ematch *e, void *data, size_t len __attribute__((unused)))
{
/*
The kernel may provide more than 4 bytes of data in the future and we want
older libnl versions to be ok with that. We want interfaces to be growable
so we only ever enforce a minimum data length and copy as much as we are
aware of. Thomas Graf.
*/
memcpy(e->e_data, data, sizeof(uint32_t));
return 0;

2
lib/route/pktloc.c
View file

@ -90,7 +90,7 @@ static int read_pktlocs(void)
YY_BUFFER_STATE buf = NULL;
yyscan_t scanner = NULL;
static time_t last_read;
struct stat st = {0};
struct stat st;
char *path;
int i, err;
FILE *fd;

8
lib/route/qdisc/htb.c
View file

@ -190,10 +190,10 @@ static int htb_qdisc_msg_fill(struct rtnl_tc *tc, void *data,
struct nl_msg *msg)
{
struct rtnl_htb_qdisc *htb = data;
struct tc_htb_glob opts = {0};
opts.version = TC_HTB_PROTOVER;
opts.rate2quantum = 10;
struct tc_htb_glob opts = {
.version = TC_HTB_PROTOVER,
.rate2quantum = 10,
};
if (htb) {
if (htb->qh_mask & SCH_HTB_HAS_RATE2QUANTUM)