stv0g/libnl
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity
libnl/lib/route
History
Justin Mayfield b62e019afa single nexthop flags bug 
I ran into a bug today related to how Linux handles a route's nexthop
flags when there is just one nexthop.  Namely Linux expects the flags
to be OR'd into the rtm_flags field when there is only one nexthop and
so rtnl_route_build_msg needs to check the number of nexthops and
store the nexthops flags into this field prior to calling
nlmsg_append(...&rtmsg).

Conversely the rtnl_route_parse function needs to pull these lower
0xff bits when a single nexthop is detected.

Attached is my patch.  I don't like the slight duplication of doing
the rtnl_route_get_nnexthops check twice but it seemed to be the least
turmoil of any solution I thought of.
2012-08-29 12:27:06 +02:00
..
cls Fix types-related warnings based on clang diagnostics 2012-06-13 13:30:26 +02:00
link Fix types-related warnings based on clang diagnostics 2012-06-13 13:30:26 +02:00
qdisc tbf: fix false missing attr 2012-08-09 14:33:38 +02:00
.gitignore Let git ignore generated pktloc source files 2010-07-03 15:56:07 +02:00
addr.c Fix types-related warnings based on clang diagnostics 2012-06-13 13:30:26 +02:00
class.c Fix types-related warnings based on clang diagnostics 2012-06-13 13:30:26 +02:00
classid.c Fix types-related warnings based on clang diagnostics 2012-06-13 13:30:26 +02:00
cls.c Fix types-related warnings based on clang diagnostics 2012-06-13 13:30:26 +02:00
link.c link: rtnl_link_get_kernel() should only wait for ACK if AUTO-ACK is on 2012-06-13 13:24:19 +02:00
neigh.c add new function to provide neighbour event parsing 2012-01-30 12:54:29 +01:00
neightbl.c Add internal wait_for_ack() which only waits for ACK if !NL_NO_AUTO_ACK 2008-10-20 13:12:13 +02:00
nexthop.c route: Add FIXME to rtnl_route_nh_set_gateway() to fix return value 2012-05-09 15:03:46 +02:00
pktloc.c fix license of lib/route/pktloc.c 2011-09-08 15:08:22 +02:00
pktloc_grammar.l Packet location updates 2010-10-27 01:21:50 +02:00
pktloc_syntax.y pktloc: support to specify a shift operator for packet locations 2010-11-04 20:01:36 +01:00
qdisc.c Fix types-related warnings based on clang diagnostics 2012-06-13 13:30:26 +02:00
route.c Documentation updates 2011-03-22 00:40:26 +01:00
route_obj.c single nexthop flags bug 2012-08-29 12:27:06 +02:00
route_utils.c constify struct trans_tbl 2010-11-17 16:09:08 +01:00
rtnl.c doc: documentation restructuring 2012-05-10 12:03:59 +02:00
rule.c missing extended Table attribute for lib/route/ 2012-03-06 10:15:30 +01:00
tc.c correct HTB rtable/HZ calculations 2012-05-29 11:42:48 +02:00