stv0g/libwebsockets
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Add error handling for SSL_new() of clients

Browse source 
Do not access wsi->ssl if SSL_new() failed and log the error.
This commit is contained in:
Patrick Gansterer 2016-08-14 19:54:12 +08:00 • committed by Andy Green
parent d4410f1d07
commit 4324ea598b
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/client.c
View file

@ -148,8 +148,10 @@ lws_client_socket_service(struct lws_context *context, struct lws *wsi,
#ifdef LWS_OPENSSL_SUPPORT
/* we can retry this... just cook the SSL BIO the first time */
if (wsi->use_ssl && !wsi->ssl)
lws_ssl_client_bio_create(wsi);
if (wsi->use_ssl && !wsi->ssl) {
if (lws_ssl_client_bio_create(wsi))
return -1;
}
if (wsi->use_ssl) {
n = lws_ssl_client_connect1(wsi);

6
lib/ssl-client.c
View file

@ -45,6 +45,12 @@ lws_ssl_client_bio_create(struct lws *wsi)
(void)param;
wsi->ssl = SSL_new(wsi->vhost->ssl_client_ctx);
if (!wsi->ssl) {
lwsl_err("SSL_new failed: %s\n",
ERR_error_string(lws_ssl_get_error(wsi, 0), NULL));
lws_decode_ssl_error();
return -1;
}
#if defined LWS_HAVE_X509_VERIFY_PARAM_set1_host
param = SSL_get0_param(wsi->ssl);