stv0g/libwebsockets
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

handle unsupported protocol correctly

Browse source 
Hi Andy,

First off, thanks for libwebsockets :-)

I've encountered a crash when a client connects to a libwebsockets server
but speicifies an unsupported protocol (Sec-WebSocket-Protocol).
handshake.c should probably be checking that wsi->protocol->name is not
null before doing a strcmp with it...
Attached is a patch for your consideration.

Cheers!
Nick

Signed-off-by: Nick Dowell <nick@nickdowell.com>
This commit is contained in:
Nick Dowell 2012-04-03 17:22:19 +01:00 • committed by Andy Green
parent 15601fd8f1
commit 5519d9f054
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/handshake.c
View file

@ -619,7 +619,7 @@ libwebsocket_read(struct libwebsocket_context *context, struct libwebsocket *wsi
if (wsi->protocol->name == NULL)
break;
} else
if (strcmp(
if (wsi->protocol->name && strcmp(
wsi->utf8_token[WSI_TOKEN_PROTOCOL].token,
wsi->protocol->name) == 0)
break;