From 5b7312213ea8fe24f17f6214863a0e2fbfbb4474 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Wed, 13 Feb 2013 09:08:43 +0800 Subject: [PATCH] disable fstack usage It's only workable on gcc 4.6+... and in fact it's only going to be interesting typically to the maintainer, so it's commented out in Makefile.am. Currently the worst remaining ones for x86_64 are libwebsockets.c:2250:6:_lws_log 496 static libwebsockets.c:2203:13:lwsl_emit_stderr 352 static client.c:700:1:libwebsockets_generate_client_handshake 320 static server.c:42:1:libwebsockets_decode_ssl_error 288 static server-handshake.c:31:1:handshake_0405 272 static client.c:368:1:lws_client_interpret_server_handshake 272 static libwebsockets.c:447:1:libwebsockets_get_peer_addresses 256 static daemonize.c:93:1:lws_daemonize 240 static output.c:536:5:libwebsockets_serve_http_file 224 static sha-1.c:131:1:sha1_step 192 static sha-1.c:316:1:SHA1 160 static libwebsockets.c:1604:1:libwebsocket_create_context 160 static The top two there are error assembly buffers, they could be made static but then they won't be usable from threaded user code. Reported-by: Anders Brander Signed-off-by: Andy Green --- lib/Makefile.am | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/Makefile.am b/lib/Makefile.am index fab1b9c3..e4f9ce01 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -44,9 +44,13 @@ else dist_libwebsockets_la_SOURCES += sha-1.c endif -libwebsockets_la_CFLAGS=-Wall -std=gnu99 -pedantic -fstack-usage +libwebsockets_la_CFLAGS=-Wall -std=gnu99 -pedantic libwebsockets_la_LDFLAGS= +# uncomment below and use cat ./lib/.libs/*.su | sort -k2g | tac +# to get a worst-first list of static stack usage if you have gcc 4.6+ +#libwebsockets_la_CFLAGS+= -fstack-usage + if USE_CYASSL libwebsockets_la_LDFLAGS+= -lcyassl endif