stv0g/libwebsockets
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

coverity 177410: check seek return value inside fops-zip

Browse source 
Truncated or corrupted zip on server side would read garbage instead of fail.
This commit is contained in:
Andy Green 2017-03-06 13:59:27 +08:00
parent 21d83b44ea
commit 688b819112
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/fops-zip.c
View file

@ -147,6 +147,7 @@ enum {
LWS_FZ_ERR_CENTRAL_READ,
LWS_FZ_ERR_CENTRAL_SANITY,
LWS_FZ_ERR_NAME_TOO_LONG,
LWS_FZ_ERR_NAME_SEEK,
LWS_FZ_ERR_NAME_READ,
LWS_FZ_ERR_CONTENT_SANITY,
LWS_FZ_ERR_CONTENT_SEEK,
@ -256,7 +257,8 @@ lws_fops_zip_scan(lws_fops_zip_t priv, const char *name, int len)
goto next;
/* we found a match */
lws_vfs_file_seek_set(priv->zip_fop_fd, priv->hdr.offset);
if (lws_vfs_file_seek_set(priv->zip_fop_fd, priv->hdr.offset) < 0)
return LWS_FZ_ERR_NAME_SEEK;
if (priv->zip_fop_fd->fops->LWS_FOP_READ(priv->zip_fop_fd,
&amount, buf,
ZL_HEADER_LENGTH))