stv0g/re
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

dns: handle dname compression loops

Browse source
This commit is contained in:
Richard Aas 2011-11-29 10:44:51 +00:00
parent 867fde2b2f
commit dc74f315ff
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/dns/dname.c
View file

@ -15,6 +15,7 @@
#define COMP_MASK 0xc0
#define OFFSET_MASK 0x3fff
#define COMP_LOOP 255
struct dname {
@ -140,15 +141,15 @@ int dns_dname_encode(struct mbuf *mb, const char *name,
int dns_dname_decode(struct mbuf *mb, char **name, size_t start)
{
uint32_t i = 0, loopc = 0;
bool comp = false;
size_t pos = 0;
char buf[256];
uint32_t i = 0;
if (!mb || !name)
return EINVAL;
while (mbuf_get_left(mb)) {
while (mb->pos < mb->end) {
uint8_t len = mb->buf[mb->pos++];
if (!len) {
@ -168,6 +169,9 @@ int dns_dname_decode(struct mbuf *mb, char **name, size_t start)
else if ((len & COMP_MASK) == COMP_MASK) {
uint16_t offset;
if (loopc++ > COMP_LOOP)
break;
--mb->pos;
offset = ntohs(mbuf_read_u16(mb)) & OFFSET_MASK;