From e2676b46409f5e90a418c1b5098c64aa04d6e0b5 Mon Sep 17 00:00:00 2001 From: Richard Aas Date: Wed, 13 Nov 2013 12:16:16 +0000 Subject: [PATCH] fix cppcheck warnings --- src/bfcp/attr.c | 2 +- src/ice/connchk.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bfcp/attr.c b/src/bfcp/attr.c index 03e62f6..7607fe0 100644 --- a/src/bfcp/attr.c +++ b/src/bfcp/attr.c @@ -127,7 +127,7 @@ static int attr_encode(struct mbuf *mb, bool mand, enum bfcp_attrib type, len = mb->pos - start; mb->pos = start; - err |= mbuf_write_u8(mb, (type<<1) | (mand&1)); + err |= mbuf_write_u8(mb, (type<<1) | (mand ? 1 : 0)); err |= mbuf_write_u8(mb, len); mb->pos += (len - BFCP_ATTR_HDR_SIZE); diff --git a/src/ice/connchk.c b/src/ice/connchk.c index ff998be..045bb5d 100644 --- a/src/ice/connchk.c +++ b/src/ice/connchk.c @@ -124,8 +124,8 @@ static void handle_success(struct icem *icem, struct candpair *cp, cp = construct_valid_pair(icem, cp, laddr, &cp->rcand->addr); if (!cp) { - DEBUG_WARNING("{%s.%u} no valid candidate pair for %J\n", - icem->name, cp->comp->id, laddr); + DEBUG_WARNING("{%s} no valid candidate pair for %J\n", + icem->name, laddr); return; }