From 297c79c9f6ca4fa4ebb7ea73ec1645d1f0ad58a4 Mon Sep 17 00:00:00 2001 From: Jaroslav Kysela Date: Fri, 3 Oct 2014 22:48:56 +0200 Subject: [PATCH] extjs: fix wrong code path in extjs_tvhlog() - coverity --- src/webui/extjs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/webui/extjs.c b/src/webui/extjs.c index cf155825..b1b90749 100755 --- a/src/webui/extjs.c +++ b/src/webui/extjs.c @@ -580,6 +580,10 @@ extjs_tvhlog(http_connection_t *hc, const char *remain, void *opaque) /* Get config */ pthread_mutex_lock(&tvhlog_mutex); m = htsmsg_create_map(); + if (!m) { + pthread_mutex_unlock(&tvhlog_mutex); + return HTTP_STATUS_BAD_REQUEST; + } htsmsg_add_u32(m, "tvhlog_level", tvhlog_level); htsmsg_add_u32(m, "tvhlog_trace_on", tvhlog_level > LOG_DEBUG); tvhlog_get_trace(str, sizeof(str)); @@ -592,7 +596,6 @@ extjs_tvhlog(http_connection_t *hc, const char *remain, void *opaque) tvhlog_options & TVHLOG_OPT_DBG_SYSLOG); pthread_mutex_unlock(&tvhlog_mutex); - if (!m) return HTTP_STATUS_BAD_REQUEST; out = json_single_record(m, "config"); /* Save settings */