From 3f4002d9845705ae2543790a99aa772f8d4ac008 Mon Sep 17 00:00:00 2001 From: Jaroslav Kysela Date: Mon, 23 Mar 2015 15:52:17 +0100 Subject: [PATCH] http: optimize dump_request(), call it also for RTSP --- src/http.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/http.c b/src/http.c index 715b69f5..289c090d 100644 --- a/src/http.c +++ b/src/http.c @@ -530,20 +530,21 @@ dump_request(http_connection_t *hc) { char buf[2048] = ""; http_arg_t *ra; - int first; + int first, ptr = 0; first = 1; TAILQ_FOREACH(ra, &hc->hc_req_args, link) { - snprintf(buf + strlen(buf), sizeof(buf) - strlen(buf), first ? "?%s=%s" : "&%s=%s", ra->key, ra->val); + ptr += snprintf(buf + ptr, sizeof(buf) - ptr, first ? "?%s=%s" : "&%s=%s", ra->key, ra->val); first = 0; } first = 1; TAILQ_FOREACH(ra, &hc->hc_args, link) { - snprintf(buf + strlen(buf), sizeof(buf) - strlen(buf), first ? "{{%s=%s" : ",%s=%s", ra->key, ra->val); + ptr += snprintf(buf + ptr, sizeof(buf) - ptr, first ? "{{%s=%s" : ",%s=%s", ra->key, ra->val); first = 0; } - snprintf(buf + strlen(buf), sizeof(buf) - strlen(buf), "}}"); + if (!first) + ptr += snprintf(buf + ptr, sizeof(buf) - ptr, "}}"); tvhtrace("http", "%s%s", hc->hc_url, buf); } @@ -728,6 +729,7 @@ process_request(http_connection_t *hc, htsbuf_queue_t *spill) switch(hc->hc_version) { case RTSP_VERSION_1_0: + dump_request(hc); if (hc->hc_cseq) rval = hc->hc_process(hc, spill); else