From 88717091704ff0a785bada5e318281de93d2eafe Mon Sep 17 00:00:00 2001 From: Jaroslav Kysela Date: Fri, 3 Oct 2014 22:06:37 +0200 Subject: [PATCH] coverity fixes - fixed string copy --- src/channels.c | 1 + src/epggrab/module/xmltv.c | 3 ++- src/wrappers.c | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/channels.c b/src/channels.c index a8357f67..3f60a658 100644 --- a/src/channels.c +++ b/src/channels.c @@ -573,6 +573,7 @@ channel_get_icon ( channel_t *ch ) } else { strncpy(buf, icon, sizeof(buf)); + buf[sizeof(buf)-1] = '\0'; } return buf; diff --git a/src/epggrab/module/xmltv.c b/src/epggrab/module/xmltv.c index d2cbe716..8b1836ba 100755 --- a/src/epggrab/module/xmltv.c +++ b/src/epggrab/module/xmltv.c @@ -67,7 +67,8 @@ static time_t _xmltv_str2time(const char *in) char str[32]; memset(&tm, 0, sizeof(tm)); - strcpy(str, in); + strncpy(str, in, sizeof(str)); + str[sizeof(str)-1] = '\0'; /* split tz */ while (str[sp] && str[sp] != ' ') diff --git a/src/wrappers.c b/src/wrappers.c index 41c28c9f..4bf3fa06 100644 --- a/src/wrappers.c +++ b/src/wrappers.c @@ -136,6 +136,7 @@ tvhthread_create0 int r; struct thread_state *ts = calloc(1, sizeof(struct thread_state)); strncpy(ts->name, name, sizeof(ts->name)); + ts->name[sizeof(ts->name)-1] = '\0'; ts->run = start_routine; ts->arg = arg; r = pthread_create(thread, attr, thread_wrapper, ts);