1
0
Fork 0
mirror of https://git.rwth-aachen.de/acs/public/villas/node/ synced 2025-03-30 00:00:11 +01:00

lab18: Apply suggestions from code review

Signed-off-by: Steffen Vogel <post@steffenvogel.de>
This commit is contained in:
Steffen Vogel 2024-10-25 12:18:26 +02:00
parent 8e26d3f982
commit 18750f2f13
2 changed files with 96 additions and 95 deletions

View file

@ -2,59 +2,59 @@
# SPDX-License-Identifier: Apache-2.0 # SPDX-License-Identifier: Apache-2.0
nodes = { nodes = {
webrtc_loopback = { webrtc_loopback = {
type = "webrtc", type = "webrtc",
format = "json" format = "json"
in = { in = {
signals = ( signals = (
{ name = "signal", type = "float", unit = "unit" }, { name = "signal", type = "float", unit = "unit" },
{ name = "signal", type = "float", unit = "unit" }, { name = "signal", type = "float", unit = "unit" },
{ name = "signal", type = "float", unit = "unit" } { name = "signal", type = "float", unit = "unit" }
) )
} }
out = { out = {
signals = ( signals = (
{ name = "signal", type = "float", unit = "unit" }, { name = "signal", type = "float", unit = "unit" },
{ name = "signal", type = "float", unit = "unit" }, { name = "signal", type = "float", unit = "unit" },
{ name = "signal", type = "float", unit = "unit" } { name = "signal", type = "float", unit = "unit" }
) )
} }
# A unique session identifier which must be shared between two nodes # A unique session identifier which must be shared between two nodes
session = "villas-test" session = "villas-test"
# Address to the websocket signaling server # Address to the websocket signaling server
server = "https://villas.k8s.eonerc.rwth-aachen.de/ws/signaling" server = "https://villas.k8s.eonerc.rwth-aachen.de/ws/signaling"
# Limit the number of times a channel will retransmit data if not successfully delivered. # Limit the number of times a channel will retransmit data if not successfully delivered.
# This value may be clamped if it exceeds the maximum value supported. # This value may be clamped if it exceeds the maximum value supported.
max_retransmits = 0 max_retransmits = 0
# Number of seconds to wait for a WebRTC connection before proceeding the start # Number of seconds to wait for a WebRTC connection before proceeding the start
# of VILLASnode. Mainly used for testing # of VILLASnode. Mainly used for testing
wait_seconds = 10 # in seconds wait_seconds = 10 # in seconds
# Indicates if data is allowed to be delivered out of order. # Indicates if data is allowed to be delivered out of order.
# The default value of false, does not make guarantees that data will be delivered in order. # The default value of false, does not make guarantees that data will be delivered in order.
ordered = false ordered = false
# Setting for Interactive Connectivity Establishment # Setting for Interactive Connectivity Establishment
# If empty then configured servers in signaling server are used. # If empty then configured servers in signaling server are used.
ice = { ice = {
# List of STUN/TURN servers # List of STUN/TURN servers
servers = ( servers = ( )
) }
} }
}
} }
paths = (
{
in = "webrtc_loopback"
out = "webrtc_loopback"
hooks = ( { type = "print" }) paths = (
} {
in = "webrtc_loopback"
out = "webrtc_loopback"
hooks = ( { type = "print" })
}
) )

View file

@ -2,71 +2,72 @@
# SPDX-License-Identifier: Apache-2.0 # SPDX-License-Identifier: Apache-2.0
nodes = { nodes = {
webrtc_siggen = { webrtc_siggen = {
type = "webrtc", type = "webrtc",
format = "json" format = "json"
in = { in = {
signals = ( signals = (
{ name = "signal", type = "float", unit = "unit" }, { name = "signal", type = "float", unit = "unit" },
{ name = "signal", type = "float", unit = "unit" }, { name = "signal", type = "float", unit = "unit" },
{ name = "signal", type = "float", unit = "unit" } { name = "signal", type = "float", unit = "unit" }
) )
} }
out = { out = {
signals = ( signals = (
{ name = "signal", type = "float", unit = "unit" }, { name = "signal", type = "float", unit = "unit" },
{ name = "signal", type = "float", unit = "unit" }, { name = "signal", type = "float", unit = "unit" },
{ name = "signal", type = "float", unit = "unit" } { name = "signal", type = "float", unit = "unit" }
) )
} }
# A unique session identifier which must be shared between two nodes # A unique session identifier which must be shared between two nodes
session = "villas-test" session = "villas-test"
# Address to the websocket signaling server # Address to the websocket signaling server
server = "https://villas.k8s.eonerc.rwth-aachen.de/ws/signaling" server = "https://villas.k8s.eonerc.rwth-aachen.de/ws/signaling"
# Limit the number of times a channel will retransmit data if not successfully delivered. # Limit the number of times a channel will retransmit data if not successfully delivered.
# This value may be clamped if it exceeds the maximum value supported. # This value may be clamped if it exceeds the maximum value supported.
max_retransmits = 0 max_retransmits = 0
# Number of seconds to wait for a WebRTC connection before proceeding the start # Number of seconds to wait for a WebRTC connection before proceeding the start
# of VILLASnode. Mainly used for testing # of VILLASnode. Mainly used for testing
wait_seconds = 10 # in seconds wait_seconds = 10 # in seconds
# Indicates if data is allowed to be delivered out of order. # Indicates if data is allowed to be delivered out of order.
# The default value of false, does not make guarantees that data will be delivered in order. # The default value of false, does not make guarantees that data will be delivered in order.
ordered = false ordered = false
# Setting for Interactive Connectivity Establishment # Setting for Interactive Connectivity Establishment
# If empty then configured servers in signaling server are used. # If empty then configured servers in signaling server are used.
ice = { ice = {
# List of STUN/TURN servers # List of STUN/TURN servers
servers = ( servers = ( )
) }
} }
}
siggen = { siggen = {
type = "signal" type = "signal"
signal = [ "sine", "pulse", "square" ] signal = [ "sine", "pulse", "square" ]
values = 3, # Number of values per sample values = 3 # Number of values per sample
limit = 1, # Number of samples to generate limit = 1 # Number of samples to generate
rate = 1, # Rate in Hz rate = 1 # Rate in Hz
} }
} }
paths = ( paths = (
{ {
in = "siggen" in = "siggen"
out = "webrtc_siggen" out = "webrtc_siggen"
hooks = ( { type = "print" }) hooks = ( "print" )
}, },
{ {
in = "webrtc_siggen" in = "webrtc_siggen"
hooks = ( { type = "print" }) hooks = ( "print" )
} }
) )