fix cppcheck warnings

common/include/villas/exceptions.hpp

@@ -101,6 +101,8 @@ protected:
 	json_t *setting;
 	json_error_t error;
 
+	std::string msg;
+
 public:
 	template<typename... Args>
 	ConfigError(json_t *s, const std::string &i, const std::string &what = "Failed to parse configuration") :
@@ -143,18 +145,17 @@ public:
 
 	virtual const char * what() const noexcept
 	{
-		std::stringstream ss;
+		if (msg.empty()) {
+			std::stringstream ss;
 
-		ss << std::runtime_error::what() << std::endl;
-		ss << " Please consult the user documentation for details: " << docUri();
+			ss << std::runtime_error::what() << std::endl;
+			ss << " Please consult the user documentation for details: " << docUri();
 
-		if (error.position >= 0) {
-			ss << std::endl << " " << error.text << " in " << error.source << ":" << error.line << ":" << error.column;
+			if (error.position >= 0)
+				ss << std::endl << " " << error.text << " in " << error.source << ":" << error.line << ":" << error.column;
 		}
 
-		auto str = new std::string(ss.str());
-
-		return str->c_str();
+		return msg.c_str();
 	}
 };
 

common/include/villas/table.hpp

@@ -49,6 +49,7 @@ protected:
 
 public:
 	TableColumn(int w, enum Alignment a, const std::string &t, const std::string &f, const std::string &u = "") :
+		_width(0),
 		width(w),
 		title(t),
 		format(f),

common/tests/unit/advio.cpp

@@ -33,6 +33,7 @@ using namespace villas;
  * The Sciebo share is read/write accessible via WebDAV. */
 #define BASE_URI "https://1Nrd46fZX8HbggT:badpass@rwth-aachen.sciebo.de/public.php/webdav/node/tests"
 
+// cppcheck-suppress unknownMacro
 TestSuite(advio,
 	.description = "Advanced file IO"
 );

common/tests/unit/base64.cpp

@@ -28,6 +28,7 @@
 
 using namespace villas::utils::base64;
 
+// cppcheck-suppress unknownMacro
 TestSuite(base64, .description = "Base64 En/decoder");
 
 static std::vector<byte> vec(const char *str)

common/tests/unit/graph.cpp

@@ -29,6 +29,7 @@
 
 using namespace villas;
 
+// cppcheck-suppress unknownMacro
 TestSuite(graph, .description = "Graph library");
 
 Test(graph, basic, .description = "DirectedGraph")

common/tests/unit/hist.cpp

@@ -31,6 +31,7 @@ const std::array<double, 10> test_data = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10};
 
 using namespace villas;
 
+// cppcheck-suppress unknownMacro
 TestSuite(hist, .description = "Histogram");
 
 Test(hist, simple) {

common/tests/unit/json_buffer.cpp

@@ -32,6 +32,7 @@ using namespace villas;
 
 using villas::JsonBuffer;
 
+// cppcheck-suppress unknownMacro
 TestSuite(buffer, .description = "Buffer datastructure");
 
 Test(json_buffer, decode)

common/tests/unit/kernel.cpp

@@ -26,6 +26,7 @@
 
 using namespace villas::kernel;
 
+// cppcheck-suppress unknownMacro
 TestSuite(kernel, .description = "Kernel features");
 
 #if defined(__x86_64__) || defined(__i386__)

common/tests/unit/list.cpp

@@ -37,6 +37,7 @@ struct data {
 	int data;
 };
 
+// cppcheck-suppress unknownMacro
 TestSuite(list, .description = "List datastructure");
 
 Test(list, vlist_lookup_name)

common/tests/unit/popen.cpp

@@ -27,6 +27,7 @@
 
 using namespace villas::utils;
 
+// cppcheck-suppress unknownMacro
 TestSuite(popen, .description = "Bi-directional popen");
 
 Test(popen, no_shell)

common/tests/unit/task.cpp

@@ -27,6 +27,7 @@
 #include <villas/task.hpp>
 #include <villas/timing.h>
 
+// cppcheck-suppress unknownMacro
 TestSuite(task, .description = "Periodic timer tasks");
 
 Test(task, rate, .timeout = 10)

common/tests/unit/timing.cpp

@@ -26,6 +26,7 @@
 
 #include <villas/timing.h>
 
+// cppcheck-suppress unknownMacro
 TestSuite(timing, .description = "Time measurements");
 
 Test(timing, time_now)

common/tests/unit/tsc.cpp

@@ -28,6 +28,7 @@
 
 #define CNT (1 << 18)
 
+// cppcheck-suppress unknownMacro
 TestSuite(tsc, .description = "Timestamp counters");
 
 Test(tsc, increasing)

common/tests/unit/utils.cpp

@@ -30,6 +30,7 @@
 
 using namespace villas::utils;
 
+// cppcheck-suppress unknownMacro
 TestSuite(utils, .description = "Utilities");
 
 /* Simple normality test for 1,2,3s intervals */