Mirrors/VILLASnode
1
0
Fork 0
mirror of https://git.rwth-aachen.de/acs/public/villas/node/ synced 2025-03-09 00:00:00 +01:00
Code Issues Releases Wiki Activity

node-webrtc: fix CI warnings

Browse source 
Signed-off-by: Philipp Jungkamp <Philipp.Jungkamp@opal-rt.com>
This commit is contained in:
Philipp Jungkamp 2023-06-15 11:24:18 +02:00
parent bb61a59103
commit 43a5292fc1
4 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/villas/nodes/webrtc.hpp
View file

@ -35,7 +35,7 @@ protected:
struct Pool pool;
std::shared_ptr<webrtc::PeerConnection> conn;
rtc::Configuration config;
rtc::Configuration rtcConf;
rtc::DataChannelInit dci;
virtual

9
lib/nodes/webrtc.cpp
View file

@ -25,6 +25,9 @@ WebRTCNode::WebRTCNode(const std::string &name) :
Node(name),
server("wss://villas.k8s.eonerc.rwth-aachen.de/ws/signaling"),
wait_seconds(0),
format(nullptr),
queue({}),
pool({}),
dci({})
{
dci.reliability.type = rtc::Reliability::Type::Rexmit;
@ -81,7 +84,7 @@ int WebRTCNode::parse(json_t *json, const uuid_t sn_uuid)
throw ConfigError(json, err, "node-config-node-webrtc-ice");
if (json_servers) {
config.iceServers.clear();
rtcConf.iceServers.clear();
if (!json_is_array(json_servers))
throw ConfigError(json_servers, "node-config-node-webrtc-ice-servers", "ICE Servers must be a an array of server configurations.");
@ -94,7 +97,7 @@ int WebRTCNode::parse(json_t *json, const uuid_t sn_uuid)
std::string uri = json_string_value(json_server);
config.iceServers.emplace_back(uri);
rtcConf.iceServers.emplace_back(uri);
}
}
}
@ -121,7 +124,7 @@ int WebRTCNode::prepare()
format->start(getInputSignals(false), ~(int) SampleFlags::HAS_OFFSET);
conn = std::make_shared<webrtc::PeerConnection>(server, session, config, web, dci);
conn = std::make_shared<webrtc::PeerConnection>(server, session, rtcConf, web, dci);
ret = pool_init(&pool, 1024, SAMPLE_LENGTH(getInputSignals(false)->size()));
if (ret) // TODO log

1
lib/nodes/webrtc/signaling_client.cpp
View file

@ -15,6 +15,7 @@ using namespace villas::node;
using namespace villas::node::webrtc;
SignalingClient::SignalingClient(const std::string &srv, const std::string &sess, Web *w) :
retry_count(0),
web(w),
running(false),
logger(logging.get("webrtc:signal"))

1
lib/nodes/webrtc/signaling_message.cpp
View file

@ -113,6 +113,7 @@ ControlMessage::ControlMessage(json_t *j)
json_t *json_connection;
size_t i;
// cppcheck-suppress unknownMacro
json_array_foreach(json_connections, i, json_connection)
connections.emplace_back(json_connection);
}