1
0
Fork 0
mirror of https://git.rwth-aachen.de/acs/public/villas/node/ synced 2025-03-16 00:00:02 +01:00
Commit graph

2120 commits

Author SHA1 Message Date
Dennis Potter
a5068e28ea Replace sleep by a better check
Prior to this commit, we called rdma_disconnect() and waited for a fixed
amount of time. This check was kind of arbitrary. Now, we keep polling
the receive Completion Queue until ib->conn.available_recv_wrs is zero
and all receive samples are thus given back to the framework.
2018-07-20 23:40:43 +02:00
Dennis Potter
8029c47113 Fixed bug which arrised in afb8b57156 2018-07-20 23:34:52 +02:00
Dennis Potter
be87846a5a Fixed way of iterating scatter/gather list 2018-07-20 22:55:33 +02:00
Dennis Potter
afb8b57156 Removed option to manually add QP type
The QP type is dependend on the port space of the RDMA CM ID. If the
RDMA CM ID is set to TCP, the QP has to be set to a RC. If it is set to
UDP, it has to be set to UD.
2018-07-19 20:42:20 +02:00
Dennis Potter
3acc3df7c4 ib_read() now works for UDP
Node is now able to send data in RDMA_PS_UDP mode. Right now it creates
a new rdma_cm_id for every connection request. We could/should do this
differently
2018-07-19 20:33:41 +02:00
Dennis Potter
2b323c3781 Fixed a bug at the send side of UDP 2018-07-19 18:47:27 +02:00
Dennis Potter
cfa93292b0 Added support for RDMA_PS_UDP at send side 2018-07-19 18:32:06 +02:00
Dennis Potter
a2ee85bd52 Check if cfg actually exists before trying to parse logging 2018-07-19 15:25:46 +02:00
Dennis Potter
84f85e137d Added STATE_CONNECTED as valid state for node_read() & node_write() 2018-07-19 14:55:07 +02:00
Dennis Potter
bf8a86ff7d Fixed typo COMMAND 2018-07-19 14:52:39 +02:00
Sonja Kolen
aaf20934fd memory: Added a fallback to use mmap without hugepages in case mmap with hugepages fails; in case the fallback is used, a warning is provided to the user 2018-07-18 16:58:07 +02:00
Sonja Kolen
5a23e64f5e added check of memory allocation failure; added check of hash table insert failure; provide warning to the user in both cases 2018-07-18 15:15:08 +02:00
1e46313d49 fix defines for websocket support 2018-07-18 08:13:47 +02:00
583e3b730f utils: seperated print_{copyright,version}(), box and color parts of utils 2018-07-18 08:13:13 +02:00
Sonja Kolen
d66268b2f8 fixed indents 2018-07-17 11:38:17 +02:00
Sonja Kolen
6c99e45264 Multiple samples can be received in a single MQTT message (Fixes #178) 2018-07-17 11:20:38 +02:00
Dennis Potter
2bee7d24dd Added rdma_event_str()
This replaces the manual translation of enumerations in the switch
statements.
2018-07-17 11:10:05 +02:00
c58a127ca5 whitespace cleanup 2018-07-17 10:52:51 +02:00
280c20de94 websocket: fix format selection in client connections 2018-07-17 10:52:51 +02:00
2a0311f05f socket: use correct values for sockaddr lengths (closes #177) 2018-07-16 21:59:23 +02:00
09742179de memory: fix segfault when releasing hugepage memory (closes #171) 2018-07-16 21:16:43 +02:00
4d54af002d memory: improve logging 2018-07-16 21:16:43 +02:00
f7f537c64b cmake: do not regenerate protobuf files if not necessary 2018-07-16 21:16:43 +02:00
e243dce812 node: fix invalid assertion in node_type() 2018-07-16 20:26:23 +02:00
7a3abc706e comedi: fix typo 2018-07-16 20:26:09 +02:00
7936b0f626 Merge branch 'cmake-include' into develop 2018-07-16 20:20:05 +02:00
b70c86cff6 fix indention 2018-07-16 20:17:08 +02:00
7c555ccb9c node: fix node_{read,write}() interface for comedi and iec61850_sv 2018-07-16 20:16:59 +02:00
aac99d626e remove obsolete Makefile 2018-07-16 20:16:22 +02:00
5bbf174a13 cmake: allow VILLASnode to be included into other CMake projects via add_subdirectory() 2018-07-16 20:16:14 +02:00
Dennis Potter
3df5d37b15 Added warning if not all samples are returned 2018-07-16 17:10:52 +02:00
688b0849bf move node_type() implementation to source file 2018-07-16 14:42:23 +02:00
77f3033007 log: remove indention feature complete for better compatability with new C++ logger 2018-07-16 14:42:11 +02:00
Dennis Potter
0230389593 Node gives back samples to framework at disconnect
The node blocks a certain amount of samples to use in its queues.
Before this commit, the only moment to release them to the framwork was
during ib_read()/ib_write().

But, there were a couple of problems. In the following I will take
ib_read() as example, but ib_write() will be analogous.

The first problem was:
1. If a QP disconnect, all Work Requests get invalidated and will be
   "flushed" to a Completion Queue.

A possible solution would be, to save them in an intermediate buffer.
We could then "exchange" these samples with the framework as soon as the node
connects again and ib_read() is called again. So, we would get valid
samples from the framwork, post them, and give the "invalidated" samples back.

But, there is a second problem:
2. We cannot assume that ib_read() is ever called again after
   ib_disconnect(). This is for example the case if the disconnect is
   triggered by ib_stop() and not by an external node that disconnects.

   This would result in a memory leak, since the samples would never be
   returned to the framework, although the node is stopped.

Because of this second problem, I decided to return all samples with
sample_put() in the disconnect function. An additional benefit is that
this is more convenient than another buffer to temporarily safe the
invalidated samples.
2018-07-16 13:41:53 +02:00
5edea6a09b use more assertions to check node state machine 2018-07-16 11:00:15 +02:00
81a2fde6a1 use new node_type() function 2018-07-16 11:00:15 +02:00
0406c46bb4 fix indention of infiniband node 2018-07-16 11:00:15 +02:00
60f55ec178 improve naming of struct node_type function pointers (closes #150) 2018-07-16 11:00:15 +02:00
Dennis Potter
d9080fa1db Cleaned up some obsolete code. Closes #176 2018-07-16 10:54:15 +02:00
Dennis Potter
d64d1e6f37 Implemented ib_reverse()
The only value that gets reversed is src- and dst address. Fixes #175.
2018-07-16 10:35:48 +02:00
Dennis Potter
eb55dee920 Added fallback which sets mode to listening mode
Before, the node would throw an error as soon as it cannot connect to
the remote host. Now, it will throw a warning and switch to listening
mode (in which it will wait for another node to connect).
2018-07-15 16:37:52 +02:00
Dennis Potter
6444a9e337 Split configuration in an in and out part 2018-07-15 13:51:18 +02:00
Dennis Potter
6975854376 Solved problem with blocking thread
In the case that a node was already disconnected but not stopped,
rdma_cm_get_event always blocked and we coulnd't join the threads. This
is solved in this commit by registering SIGUSR1 to the CM event thread.

This bug originated in issue #152
2018-07-14 16:46:23 +02:00
Dennis Potter
3d01174859 Merge branch 'ib-send-inline' into develop 2018-07-14 15:26:12 +02:00
Dennis Potter
95e2a7c20b Added extra check for inline mode. Closes #164
The actual maximum size for inline mode is now returned to the user and
there is a check that inline_mode is either 0 or 1. Furthermore, this
commit includes a minor improvement in ib_write()
2018-07-14 15:20:24 +02:00
Dennis Potter
1d6ee5aec8 Node can determine if data should be send inline
The user can set the maximum size of the inline data and the node checks
if a sample can be send inline. This commit doesn't contain a info
message to the user about what the final max inline size will be. (The
HCA will probably change the value set by the user.)
2018-07-13 13:50:30 +02:00
Sonja Kolen
bfd25b55db check if publish/ subscribe topic is set before subscribing or publishing, provide a warning to the user in case subscribing/ publishing cannot be done because of lack of topic 2018-07-13 13:36:13 +02:00
Dennis Potter
b1b778f542 Added buffer to ib_write()
Now, ib_write() reads every cycle cnt values from the Completion Queue.
If it is not able to return them to the framework immediately, it
temporarily saves them on a stack.

ib_write() checks every cycle if the stack is non-empty and if it is
possible to return values from the stack to the framework.
2018-07-13 12:21:59 +02:00
Dennis Potter
4cd8fc7150 ib_write and ib_read handle memory in a way that the pool doesn't underrun now. Sending data inline is broken in this commit 2018-07-12 17:49:17 +02:00
Dennis Potter
51c26c0bb1 Merge branch 'node-read-write-interface' into develop 2018-07-11 23:03:59 +02:00