1
0
Fork 0
mirror of https://github.com/alice-lg/birdwatcher.git synced 2025-03-23 00:00:07 +01:00
Commit graph

248 commits

Author SHA1 Message Date
Benedikt Rudolph
14c8875ae0 Avoid overwriting existing cache entry
also fix RoutesNoExport.
2019-02-28 13:25:47 +01:00
Benedikt Rudolph
7e02cb23da Add test for memory cache backend
Improve error handling in case value can not be retrieved.
Either return the value and nil, or a value and an error.
2019-02-28 13:02:11 +01:00
Benedikt Rudolph
119b9f6360 Add feature cache backends
Add support for various cache backends in anticipation of the
merge with master that has an additional redis backend.
The current memory based cache backend is refactored to implement
the new interface.
2019-02-28 11:32:40 +01:00
Benedikt Rudolph
ceea37e53b Merge branch 'upstream/master' into develop
Merge changes including version 1.11.0 of upstream.
Remove extra lines in RoutesNoExport()

Conflicts:
       README.md
       * Keep `birdwatcher` in the configuration path
       bird/bird.go
       * Keep the default order of arguments to birdc in RoutesFiltered() and RoutesNoExport()
       birdwatcher.go
       * Keep `gorilla/handlers` for HTTP logging
2019-02-28 09:17:41 +01:00
Patrick Seeburger
12be0f9de3 Fixed a bug where a community was missing when parsing multiline communities.
Also added a test case for the multiline community parsing.
2019-03-13 09:29:58 +01:00
Patrick Seeburger
49fb6882fa Removed unused OrigTTL attribute from cache info. 2019-03-13 09:29:57 +01:00
Patrick Seeburger
681fcc60ea Removed timestamp from logging output. 2019-03-13 09:29:55 +01:00
Patrick Seeburger
791b2a04ba Fixed the regular expression to not match white spaces at the end of
the protocol line.

Fixed the route sample which was failing the parser tests.
2019-03-13 09:29:55 +01:00
Benedikt Rudolph
5e49d6d4a3 Fix default config path
Instead of /etc/birdwatcher the config file location was assumed to
be in etc/birdwatcher relative to the working directory at execution.
2019-03-13 09:29:53 +01:00
Patrick Seeburger
c1db0320e3 Implemented handling of multiline replies in case of BGP.*community 2019-03-13 09:29:53 +01:00
Patrick Seeburger
3eca6db998 Add "Last Error" to protocols bgp test case. 2019-03-13 09:29:51 +01:00
Patrick Seeburger
83628d4995 Cache refactoring, allow update before store
* Change the callback type to update the cache for RunAndParse()
  to be a pointer to the Parsed record, which allows updating the
  Parsed record before it will be stored inside the cache
2019-03-13 09:29:15 +01:00
Patrick Seeburger
01eb78117b Refactor use of the Meta Cache
* Update all functions that use the meta cache to only create
  their own records and also use GetCacheKey() to request the
  meta cache from other functions.
  * eliminates the need for Clear() -> removed
* Add two new birdc commands:
  * PipeRoutesFiltered()
  * PipeRoutesFilteredCount()
2019-03-13 09:29:15 +01:00
Patrick Seeburger
50a79e7f4f Add the GetCacheKey() function
This allows to determine the key in the cache, where the result of
specific functions are stored, without requiring to know what command
was executed by that function.
Also updated all functions to use GetCacheKey() to store Parsed
records.
2019-03-13 09:29:14 +01:00
Patrick Seeburger
d931094ce7 Introduce a new birdc query RoutesFilteredCount()
The query can be used to determine the exact number of filtered
(not exported) prefixes from a table towards a pipe protocol for
a certain neighbor (if multiple neighbors are connected to
the given table).
2019-03-13 09:29:14 +01:00
Patrick Seeburger
c3d0d16b48 Fixed a bug in RoutesDumpPerPeerTable()
The bug causes an early exit if the filtered routes for a protocol
can not be retrieved.
2019-03-13 09:29:14 +01:00
Patrick Seeburger
3e63268af3 Implement a RunQeue for birdc commands
This prevents running the same birdc command multiple times in
parallel.
2019-03-13 09:29:13 +01:00
Patrick Seeburger
ced455ef7b Cache redesign - Parsed and Meta cache separation
* seperate Parsed and Meta cache, so that they may be locked independently
* extend the RunAndParse() function to allow the caller to specify a
  callback which will update the Meta cache
* change all methods interacting with the Meta cache to use the
  callback for RunAndParse() to update the Meta cache
2019-03-13 09:28:59 +01:00
Patrick Seeburger
980fcff9c2 Changed the data structure for the extended communities to be a single
slice of {string, int64, int64} instead of a parsed record.
2019-02-22 14:07:11 +01:00
Patrick Seeburger
95cf1a71af Fixed a bug in the parser that would return an integer of the wrong type
(int vs. int64) in an error case.
2019-02-22 14:07:11 +01:00
Patrick Seeburger
7fd2dfd0cf Implement new endpoint /routes/count/primary 2019-02-22 14:07:10 +01:00
Patrick Seeburger
541ea6d84d Fix RoutesDumpPerPeerTable()
Fix RoutesDumpPerPeerTable to return results again and the filtered
routes.
2019-02-22 14:07:10 +01:00
Patrick Seeburger
c1a07cc985 Implemented support for parsing extended communities. 2019-02-22 14:07:10 +01:00
Patrick Seeburger
b7952f9061 Fix TestParseProtocolBgp()
Fix test method TestParseProtocolBgp() to match the output of the
current ProtocolsBgp() method wich returns Parsed records instead of a
string array.
2019-02-22 14:07:09 +01:00
Patrick Seeburger
08c63fc3a3 Fixed /routes/count/protocol Endpoint which was returning no data,
because the wrong parser was called.
2019-02-22 14:07:09 +01:00
Patrick Seeburger
6e8734fa90 Fixed /symbols endpoint. 2019-02-22 14:07:09 +01:00
Johannes Moos
439ee0d5d0 Fix RoutesPrefixed
This version ignored the prefix which is passed as an URL parameter.
2019-02-22 14:07:08 +01:00
Patrick Seeburger
b8b9b5d021 Fixed /routes/count/table Endpoint which was returning routes instead of
a route count because the wrong method was called.
2019-02-22 14:07:08 +01:00
Patrick Seeburger
4ffebab2c4 Fixed race condition between main() and InstallRateLimitReset(). 2019-02-22 14:07:08 +01:00
Patrick Seeburger
27fe2969d7 Avoid unnecessary cache writes in /status
Introduce check to avoid unneccesarry cache writes.
2019-02-22 14:07:07 +01:00
Benedikt Rudolph
337e2288e8 Add info on show route command 2019-02-22 14:07:07 +01:00
Benedikt Rudolph
e8cb296397 Add doc on interpretation of route count numbers
We hope to clarify with the given examples the semantics of route counts.
2019-02-22 14:07:07 +01:00
Patrick Seeburger
8a69b5ba98 Repair 'protocols' endpoint
* repair 'protocols' endpoint to return a meaningful JSON object
* improve example configuration file
2019-02-22 14:07:06 +01:00
Matthias Hannig
712510b3bc include caching information alongside ttl 2019-02-22 14:07:06 +01:00
Daniel Czerwonk
f82f265612 fixed vendoring 2019-02-22 14:06:37 +01:00
Benedikt Rudolph
ac1c385048 Conclude de-ecixification 2019-02-20 17:27:02 +01:00
Benedikt Rudolph
821a4f869a Change Go import paths for alice-lg github org 2019-02-20 17:25:57 +01:00
Benedikt Rudolph
a171284a9b Change URLs to alice-lg github organization 2019-02-20 17:25:57 +01:00
Matthias Hannig
5872eeb5e8 version bump 2018-11-29 15:28:19 +01:00
Matthias Hannig
2a17304682 fixed command syntax 2018-11-29 15:28:00 +01:00
Matthias Hannig
e7755afb61 moved repository (alice-lg) in import 2018-11-29 15:20:45 +01:00
Johannes Moos
ce8e7c437c Add "routes_peer" module to list in example config 2018-07-18 10:56:32 +02:00
Patrick Seeburger
c1cc320030 Improve caching of parsed birdc output.
This additionally caches the results after matching regular
expressions and improves performance further.

Credits: Hasan Pekdemir for the original idea.
2018-07-18 10:53:53 +02:00
Benedikt Rudolph
715deaebb8 Fix quotation error Routes{Table,Lookup}* method
The commands submitted to birdc contain "'" characters
placed before and after ip-address/prefix and table
name. In normal operation of birdc they are eliminated
by the shell. However when given as arguments to birdc
directly they cause "IP address expected" error in Bird.

Credits: Felix Singer for finding and submitting this bug.
2018-07-18 10:53:07 +02:00
Benedikt Rudolph
fdfa4cbc32 Generalize parse method to accept all protocols
The method parseBgp is now generic enough to  parse
all types of protocols.
Added new regular expressions and a more flexible
way of processing route_change statistics that have
subtle differences in each protocol.
2018-07-18 10:43:00 +02:00
Benedikt Rudolph
88eb405c9e Add comment to explain "-r" argument. 2018-07-18 10:43:00 +02:00
Benedikt Rudolph
1ccbc3d702 Execute birdc in restricted mode with "-r" argument. 2018-07-18 10:42:59 +02:00
Benedikt Rudolph
a89bc7049b Cleanup
Eliminate use of fmt, use log instead.
Fix timestamps in logs.
2018-07-18 10:42:59 +02:00
Benedikt Rudolph
b1f8b2a6d5 Fix enable_tls config option and logger 2018-07-18 10:42:59 +02:00
Hasan Pekdemir
494c54d061 Fix custom logger and add more comments 2018-07-18 10:42:58 +02:00