Andy Green
fe7fdef9be
clean: SSL_accept failure just needs info logging
2020-08-31 16:51:37 +01:00
21stcaveman
8ca839dfb0
Subject: plugins: lwsws will not iterate all plugin directories
...
Apply the same logic to both libuv and the generic unix plugin implementations
2020-08-31 16:51:37 +01:00
Andy Green
72b245ea38
h2: fix breakage with LWS_WITH_HTTP2=0
2020-08-31 16:51:37 +01:00
Andy Green
d735d96b99
sspc: extend assert length check to explicit code
2020-08-31 16:51:37 +01:00
Andy Green
21a22d20ca
test-apps: dont build extension support if LWS_WITHOUT_EXTENSIONS
2020-08-31 16:51:37 +01:00
Andy Green
28f4aae555
listen: network filter: provide a struct with client info to the FILTER cb
...
For backwards compatibility, keep the cast fd on in and pass an info struct
to the callback by overloading user_data.
2020-08-31 16:51:37 +01:00
Andy Green
62c328244c
cmake: fix things ignoring LWS_WITH_TLS
2020-08-31 16:51:36 +01:00
Yucong Sun
8584c973fa
adopt: disable ssl flags if ssl not enabled
...
https://github.com/warmcat/libwebsockets/issues/2011
2020-08-31 16:51:36 +01:00
Andy Green
2330f69082
add braces around possibly preprocesssor removed helper
2020-08-31 16:51:36 +01:00
Andy Green
1ebe27e38f
cmake: mark all the subprojects as explicitly C
...
We don't need a C++ compiler but if we don't spell it out, cmake
assumes it C + C++ compiler needed.
2020-08-31 16:51:36 +01:00
Andy Green
692f269045
coverity: 62140: if newer mbedtls apis available use and check returns
...
mbedtls has older and newer hashing apis, if we detected the newer ones
we use them like the older ones since generally, hashing doesn't have a
way to fail for sha and md5 update etc.
Coverity objects... change it to dumbly check the retcode.
2020-08-19 07:46:21 +01:00
Andy Green
c21467a8f0
coverity: 50976: check fsync return for cert write
2020-08-19 07:23:19 +01:00
Andy Green
e2dcbdc81a
coverity: 49785: confirm initgroups worked
2020-08-19 07:21:55 +01:00
Andy Green
258ee1886f
coverity: 37468: confirm gethostname worked
2020-08-19 07:19:48 +01:00
Andy Green
d69b91d2d9
coverity: 62123: explicitly check things to guide coverity
...
Coverity sees we sometimes check if header length is 0 and extrapolates
from that not checking header length return is a violation. But often
we are OK if the header length is 0 and there is no error return to
check from that.
It also doesn't understand that if we saw a nonzero length for a header,
then we are going to get a non-null simple_ptr() return for sure. Just
give up and explicitly, unneccessarily check everything so coverity can
stop telling us about it.
2020-08-19 07:11:59 +01:00
Andy Green
944ef24e67
coverity: 10600: make sure vhosts get off the pending destruction list if on it
2020-08-19 06:52:47 +01:00
Andy Green
a8315807e7
coverity: 10417: move goto inside preprocessor conditional that needs it
...
Otherwise coverity sees it with !defined(LWS_ROLE_WS) sitting there doing nothing
2020-08-19 06:46:19 +01:00
Andy Green
7ff64b3c42
coverity: 10117: help coverity understand simple_ptr cannot be NULL
2020-08-19 06:40:13 +01:00
Andy Green
a743a2b234
coverity: 62207: we only need to compute the flag if LWS_WITH_SYS_ASYNC_DNS
2020-08-18 14:00:54 +01:00
Andy Green
a6b4bd8bfc
coverity: 62374: no need to init n
2020-08-18 14:00:54 +01:00
Andy Green
9679222070
coverity: 62147: setting retcode var is cruft
2020-08-18 14:00:54 +01:00
Andy Green
76ee92afb4
coverity: 62574: wsi mux close: dumb down iterator so no dead code
2020-08-18 14:00:54 +01:00
Andy Green
cc5fb48598
coverity: 21034: dont bother assigning shutdown api return
2020-08-18 14:00:54 +01:00
Andy Green
ad6dfd3df6
coverity: 21071: no need to init accept_fd
2020-08-18 14:00:54 +01:00
Andy Green
7ded454d2d
coverity: 62570: back up assert with unconditional NULL check
2020-08-18 14:00:54 +01:00
Andy Green
84a8ada0fd
coverity: 62181: remove needless wsi check
2020-08-18 14:00:54 +01:00
Andy Green
d5497d5f55
coverity: 62535: another simple_ptr NULL check after confirmed by other means
2020-08-18 14:00:54 +01:00
Andy Green
520befb554
coverity: 61708: privkey required for mbedtls
2020-08-18 14:00:54 +01:00
Andy Green
7b847f8315
coverity: 62212: coverity says its dead code
2020-08-18 14:00:54 +01:00
Andy Green
264c98c2c9
coverity: 62494: check system blob supposed to be used in h1 at runtime
2020-08-18 14:00:54 +01:00
Andy Green
80ea883796
coverity: 62550: back up assert with runtime NULL check
2020-08-18 14:00:54 +01:00
Andy Green
acf42bec9d
coverity: 62211: use lws_protocol_init retcode in context init
2020-08-18 14:00:54 +01:00
Andy Green
6b09e5f8f7
coverity: 62313: static blob cant be null but coverity needs convincing
2020-08-18 14:00:54 +01:00
Andy Green
398a9e1bad
coverity: 62134: protect debug-only statement with preprocessor conditional
...
Compiler has no problem with it but coverity complains nobody uses p in release build
2020-08-18 14:00:54 +01:00
Andy Green
598a82ca1d
coverity: 62512: remove unused assignment
2020-08-18 14:00:54 +01:00
Andy Green
5ef6c548d8
coverity: 62488 62253: comment NOP left in for extensibility
2020-08-18 14:00:54 +01:00
Andy Green
260bd38d56
coverity: 62319: coverity thinks we must always check blob size
2020-08-18 14:00:54 +01:00
Andy Green
d3d8b3a74c
coverity: 62370: reassure coverity static blob always exists
2020-08-18 14:00:54 +01:00
Andy Green
03ab5b5247
coverity: 62376: reassure coverity static blob always exists
2020-08-18 14:00:54 +01:00
Andy Green
80395f479f
coverity: 62431: reassure coverity static blob always exists
2020-08-18 14:00:54 +01:00
Andy Green
fc9a23abeb
coverity: 62581: lwa auth: handle illegal blob index
2020-08-18 14:00:54 +01:00
Andy Green
1892af1ce3
coverity: 40529: add needless check on NULL simple_ptr after confirmed it has nonzero length
2020-08-18 14:00:54 +01:00
Andy Green
630391e0fb
coverity: 50320: show coverity protocol can always be found by name
2020-08-18 14:00:54 +01:00
Andy Green
b1281f1f3a
coverity: 50773: no need to set m any more when transitioning and exiting
2020-08-18 14:00:54 +01:00
Andy Green
cdbf86fe4a
coverity: 51248: convince coverity we have an ah attached before dereference during parse
2020-08-18 14:00:54 +01:00
Andy Green
b63c7f1e8e
coverity: 62131: check when logging role name for NULL
2020-08-18 14:00:54 +01:00
Andy Green
06005d14b4
coverity: 62154: calculation needed if WITH_FILE_OPS
2020-08-18 09:34:50 +01:00
Andy Green
048604751c
coverity: 62584: init m only inside preprocessor conditional that needs it
2020-08-18 09:28:40 +01:00
Andy Green
60e2c65208
coverity: 62333; no need to init cce as set on all paths that use it
2020-08-18 09:19:34 +01:00
Andy Green
400355fdc3
coverity: 62458: coverity doesnt understand nonzero header length means simple_ptr cannot be NULL
2020-08-18 09:19:33 +01:00