The effect of this bug was that kicking a non-existant user crashed pidgin.
Whoops.
Cannot be a 'g_return_if_fail', as that would leave
messages looking like errors in the log.
Fixes#305, fixes#339, fixes#394
Quick and dirty solution, by just checking for these tags by string matching.
This technically introduces a new bug:
If pidgin adds *two* tags like this:
<span>First text</span><span>Second text</span>
… then everything goes bad. We won't try to salvage messages which are broken like this.
Don't use a file for the pubkey; merge Debian stuff
- Don't use a file for the pubkey: Reading the pubkey caused a lot of pain in the past. Nobody complained about the format change, and there is only one Telegram pubkey anyway. So it's reasonable to assume that this feature is completely pointless. Also, tgl carries a hardcoded copy of the key anyway. So reading the key from memory instead of the filesystem is much less painful, and has essentially no cost.
- merge Debian stuff: I stopped trying to push this into the Debian repository, since Telegram, tgl, and telegram-purple are too fast-paced and unstable. However, there was someone who wanted a package, and I dislike the bad state of the Ubuntu package. Including this complete and up-to-date debian/ folder means: users can easily build their own .deb package, and the Ubuntu package will hopefully see an increase in quality (at least debian/copyright, please).
Sadly, Transifex doesn't seem to acknowledge that the generated files
are bad. Also, I don't want to introduce any infrastructure to
fix the files every time after I download them.
So they stay broken, and the warnings must be silenced.
Sadly, this means that future warnings will get ignored, too.
Let's hope this won't go too bad.
Ahh, right, thankyou make, for reminding me that 'all' isn't actually
any automagically chosen target that is chosen when no target has been
specified. No, instead, the first target is chosen.
And not just any target! Only the first non-templated target is chosen,
so in this case: po/telegram-purple.metainfo.xml.pot .
However, in our case that's utterly pointless, so 'all' needs to
be on top again. I should have known there was an important reason.