Commit graph

5212 commits

Author SHA1 Message Date
Jaroslav Kysela
284f70f19c httpc: coverity - used another variable in http_client_ssl_shutdown() 2014-10-03 17:43:43 +02:00
Jaroslav Kysela
b22085ee72 htsmsg: fix htsmsg_list_2_csv() first variable - coverity 2014-10-03 17:37:48 +02:00
Jaroslav Kysela
60aeeac40d filebundle: fix possible buf overflow in fb_scandir() - coverity 2014-10-03 17:31:29 +02:00
Jaroslav Kysela
a0e4c0133c epgdb: epg_init - fix possible negative value - coverity 2014-10-03 17:29:24 +02:00
Jaroslav Kysela
0cb732174d epg: _eq_add - move e == NULL check - coverity 2014-10-03 17:27:20 +02:00
Jaroslav Kysela
aff146364e config: coverity - missing NULL check 2014-10-03 17:25:38 +02:00
Jaroslav Kysela
52c812280a htsmsg: add missing va_end() calls - coverity 2014-10-03 17:20:19 +02:00
Jaroslav Kysela
2e858f339c epgdb: check return value in epg_save() 2014-10-03 17:18:56 +02:00
Jaroslav Kysela
f7a328ff3c service: remove dead code (esf_service) - coverity 2014-10-03 17:17:24 +02:00
Jaroslav Kysela
af518e9be4 subscriptions: reshuffle code in subscription_unlink_mux() - coverity 2014-10-03 17:15:56 +02:00
Jaroslav Kysela
749ce2efec esfilter: remove dead code (coverity) 2014-10-03 17:14:37 +02:00
Jaroslav Kysela
1cb1f674a0 filebundle: coverity - fix possible buf overflow in fb_readdir() 2014-10-03 17:03:33 +02:00
Jaroslav Kysela
152dc614e8 htsmsg: coverity - add missing break in htsmsg_field_get_string() 2014-10-03 17:02:08 +02:00
Jaroslav Kysela
1eb67bacf5 idnode: remove dead code - coverity 2014-10-03 17:00:43 +02:00
Jaroslav Kysela
bc1d444ed9 settings: coverity - possible buf overflow 2014-10-03 16:58:39 +02:00
Jaroslav Kysela
b2913639c4 tvhlog: cleanup tvhlog_queue on shutdown 2014-10-03 16:47:54 +02:00
Jaroslav Kysela
3d3d24aa3e epg: coverity - fix _epg_sort_title_ascending() 2014-10-03 16:08:48 +02:00
Jaroslav Kysela
49c5896b4b settings: add missing va_end() call to hts_settings_vload() - coverity 2014-10-03 16:04:43 +02:00
Jaroslav Kysela
3c7990b7e0 config: another coverity fix in config_modify_tag() 2014-10-03 15:58:30 +02:00
Jaroslav Kysela
a28696f4f9 subscriptions: subscription_create_from_mux() reshuffle some wrong code (coverity) 2014-10-03 15:56:51 +02:00
Jaroslav Kysela
854f4dfbae htsp server: fix len variable type in htsp_read_message() - coverity (signess) 2014-10-03 15:53:55 +02:00
Jaroslav Kysela
6daddcc761 filebundle: fix wrong malloc() in fb_scandir() - coverity 2014-10-03 15:52:02 +02:00
Jaroslav Kysela
0b991efe32 htsbuf: add two missing va_end() calls to htsbuf_vqprintf() 2014-10-03 15:49:38 +02:00
Jaroslav Kysela
02e2633c2a settings: add missing va_end() - coverity 2014-10-03 15:46:27 +02:00
Jaroslav Kysela
0ff555b50c cron: coverity chack for NULL string in cron_parse_val() 2014-10-03 15:45:04 +02:00
Jaroslav Kysela
d4611d147c tcp: coverity don't close(-1) 2014-10-03 15:44:43 +02:00
Jaroslav Kysela
d5712f1031 idnode: fix get functions (islist) - coverity 2014-10-03 15:26:42 +02:00
Jaroslav Kysela
f0e4ec0e10 config: coverify - fix possible NULL dereference 2014-10-03 15:21:47 +02:00
Jaroslav Kysela
fb30be0a6f tvhlog: tvhlog_thread - remove dead code (coverity) 2014-10-03 15:19:28 +02:00
Jaroslav Kysela
0f592f4d02 service: fix service_class_caid_get() snprintf - coverity 2014-10-03 15:17:41 +02:00
Jaroslav Kysela
3228f400f8 idnode: coverity fix variable initialization in idnode_filter_init() 2014-10-03 15:16:04 +02:00
Jaroslav Kysela
7544c6e9b0 prop: add extra assert to prop_read_value() 2014-10-03 15:13:03 +02:00
Jaroslav Kysela
5fff5d40bc coverity: fix memory leak in idnode_filter() 2014-10-03 15:08:21 +02:00
Jaroslav Kysela
ef4cebdb92 fsmonitor: coverity - fix variable access (beyond) 2014-10-03 15:02:39 +02:00
Jaroslav Kysela
36254905d7 htsp server: fix wrong fd condition (coverity) 2014-10-03 14:59:04 +02:00
Jaroslav Kysela
fc915fcdc4 fsmonitor: coverity - fsmonitor_fd cannot be negative 2014-10-03 14:57:07 +02:00
Jaroslav Kysela
60aa4e2658 tcp: connect - fix another memory leak (coverity) 2014-10-03 14:51:24 +02:00
Jaroslav Kysela
e136a37514 trap: fix digest variable initialization (coverity) 2014-10-03 14:50:25 +02:00
Jaroslav Kysela
7c2a37a6a1 imagecache: fix the url variable initialization for error path (coverity) 2014-10-03 14:49:01 +02:00
Jaroslav Kysela
7fc28acf56 http: handle negative value from base64_decode (coverity) 2014-10-03 14:47:23 +02:00
Jaroslav Kysela
1589bd8326 huffman: remove wrong htsmsg_destroy() call (coverity) 2014-10-03 14:45:18 +02:00
Jaroslav Kysela
07d5b1118e imagecache: coverity - fix wrong unlink() call 2014-10-03 14:42:26 +02:00
Jaroslav Kysela
a7e6993c13 tcp: fix memory leak in error path in tcp_server_create() (coverity) 2014-10-03 14:40:00 +02:00
Jaroslav Kysela
45d3685cd7 config: wrong map fix in v6 migrate (coverity) 2014-10-03 14:36:22 +02:00
Jaroslav Kysela
a03b8b06ae timeshift: reader - coverity - access to variable after free() 2014-10-03 14:35:37 +02:00
Jaroslav Kysela
a97c73d96e access: coverity - handle negative value from base64_decode() 2014-10-03 14:35:32 +02:00
Jaroslav Kysela
cb2e79788c intlconv: Add some missing close calls (coverity) 2014-10-03 14:17:04 +02:00
Jaroslav Kysela
22f0608421 htsp: reshuffle some code to prevent unexpected async messages on shutdown
valgrind reported:
   Invalid write of size 8
      at 0x43000F: htsp_serve (htsp_server.c:2510)
      by 0x4147D2: tcp_server_start (tcp.c:447)
      by 0x412250: thread_wrapper (wrappers.c:125)
      by 0x771CB4F: start_thread (pthread_create.c:304)
      by 0x7E97E6C: clone (clone.S:112)
    Address 0x11c30ca8 is 120 bytes inside a block of size 264 free'd
      at 0x4C27D4E: free (vg_replace_malloc.c:427)
      by 0x42FF27: htsp_serve (htsp_server.c:2488)
      by 0x4147D2: tcp_server_start (tcp.c:447)
      by 0x412250: thread_wrapper (wrappers.c:125)
      by 0x771CB4F: start_thread (pthread_create.c:304)
      by 0x7E97E6C: clone (clone.S:112)

The client was removed from the async list after all connections
were destroyed, but queues are part of the connection structure,
so sporadically, an async msg was queued after the queue flush.

This code change moves the async unlink before the connection
destroy call.
2014-10-03 11:36:10 +02:00
Jaroslav Kysela
604ff922fa mpegts service: use dvb_network_get_orbital_pos() in the picons code for dvb-s 2014-10-03 11:01:37 +02:00
Jaroslav Kysela
9a5e31449a mpegts service: fix memory leak - s_dvb_cridauth 2014-10-03 10:06:50 +02:00