The sink reordering would fail on retrieval of tiling information from a sink
that does not have a Tiled Display Topology (TDT) data block. This behavior is
incorrect since subsequent sinks may be a part of a tiled display.
Modified the function to be void.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
Added functionality that reorders the sink list such that topologies containing
tiled display(s) will have the contained sinks reordered in a consistent manner.
The need for such functionality exists because not all tiled displays will have
the same internal topologies.
It was observed that two 4k2k MST based monitors (tiled display, 2 sinks) from
different manufacturers would have the left and right images swapped using
identical stream-to-sink mappings.
Thus, the need to obtain the tiled display topology information of all sinks and
their relative tile location is required to send the correct stream to the
desired sink.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
These macros parse tile location, total horizontal and vertical tiles, and tile
order from the Tiled Display Topology section data block.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
Given a sink, the function will attempt to retrieve the Tiled Display Topology
section data block which is part of the DisplayID structure.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
The Tiled Display Topology (TDT) section data block is part of the DisplayID.
The driver currently supports DisplayID as an extension block to the base EDID
structure.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
Given a sink, the function will attempt to retrieve an EDID extension block of
type DisplayID.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
Created a file containing utility functions related to the Extended Display
Identification Information (EDID).
The initial functions included are used to fetch EDID blocks.
Block numbering starts with 0 being the base EDID block, and extension block
starting at 1.
EDID blocks are 128 bytes in size.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
The 16-byte chunking is already done by XDptx_AuxCommon, so there is no need to
do it in XDptx_IicRead.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
- Added function header comments for the remote I2C and remote DPCD read and
write functions.
- Updated the function header comments for immediate I2C and AUX read and write
functions.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
Some monitors don't support sideband messages with IIC reads greater than 16
bytes. This improvement breaks up the higher-level read/write request into
multiple reads/writes that work with up to 16 bytes in size.
These higher-level remote IIC read/write functions also serve as a wrapper for
an IIC read/write in case that the link count total is equal to 1 (a read/write
request to the RX device directly connected to the TX (not "remote")).
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
The remote read/write functions serve as a wrapper in case the target RX device
is directly connected to the TX (link count total is equal to 1).
These functions may be called instead of the read/write GUID functions doing the
same thing.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
Some monitors don't support sideband messages with AUX reads greater than 16
bytes. This improvement breaks up the higher-level read/write request into
multiple reads/writes that work with up to 16 bytes in size.
These higher-level remote DPCD read/write functions also serve as a wrapper for
an AUX read/write in case that the link count total is equal to 1 (a read/write
request to the RX device directly connected to the TX (not "remote")).
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
- Changed the offset from type u8 to u16.
- In order to accomodate offsets greater than 255, a segment pointer is used.
- The I2C read funciton is now able to access blocks other than the
block 0 and 1 at a given address. E.g., EDID extension blocks may now be
accessed by reading from I2C address 0x50 (raw=0xA0/0xA1) and writing
the appropriate segment pointer and offset.
- Input offset=0.
- EDID block 0: I2C read on offset=0 and segptr=0.
- Input offset=128.
- EDID block 1: I2C read on offset=128 and segptr=0.
- Input offset=256.
- EDID block 2: I2C read on offset=0 and segptr=1.
- Input offset=384.
- EDID block 3: I2C read on offset=128 and segptr=1.
- etc.
- Writing to the I2C address 0x30 (raw=0x60/0x61) sets the segment
pointer.
- Writing to an I2C address sets the offset that will be read from that
address. E.g., a read of the EDID, starting at offset 128 would be done
by writing 128 to 0x50, then reading from 0x50.
- Offsets that cross a 256-byte boundary requiring increment of the
segment pointer is also handled. E.g. A 16 byte read on input offset 500
results in the the returned 16 byte array having the first 11 bytes from
segptr=1 (bytes 244-255) and the last 5 bytes from segptr=2 (bytes 0-4).
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
An LCR (link count remaining) value of 6 is used to protect against loops.
If the LCR isn't processed at each node and attempted to be broadcasted on all
ports, waiting for a reply, a loop in the topology will result in the broadcast
message being forwarded infinitely.
Because of this, an LCR of 0 will prevent the message from being forwarded to
subsequent DP nodes.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
- Reduced lines of code that weren't part of the minimal set required for MST
streams to appear on the monitors.
- By default, don't use delays for AUX or sideband messaging.
- Added a final check to make sure that the link hasn't been lost. If it was
lost, re-train and try the programming sequence again.
- Added some additional comments to example code.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
It was observed that in MST mode, some of the sideband message were failing
due to the first check not showing a connected device.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
Increased waiting for a response to a sideband message before timing out.
Reduced number of reads to check that the RX device received an ACT event.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
Changes to the API in v2_0:
- XDptx_FindAccessibleDpDevices returns u32 now instead of void previously.
- Added a wrapper function: u32 XDptx_DiscoverTopology(XDptx *InstancePtr);
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
Testing with the new IP configuration parameter (payload data width) required
some changes to the examples.
Signed-off-by: Andrei-Liviu Simion <andrei.simion@xilinx.com>
